Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async behaviour #1451

Closed
wants to merge 12 commits into from

Conversation

saileshkotha
Copy link

Description
Removed logic where async changes the integration to AWS
Added logic to ignore the result of lambda and return a 200
Added body parsing (it parses both application/x-www-form-urlencoded and application/json).
Motivation and Context
https://www.serverless.com/framework/docs/providers/aws/events/apigateway#using-asynchronous-integration

Fixes the behavior of adding the async option to HTTP events.

When async is added, the API Gateway should auto-respond with a 200 and then invoke the lambda asynchronously with the same event as a regular lambda proxy event as described in the docs above.

How Has This Been Tested?
Unit Test
Running Locally

@saileshkotha
Copy link
Author

@dherault Can you please approve the running workflow? We fixed tests in the current branch. We need the async behavior in our projects.

@dnalborczyk dnalborczyk reopened this Sep 24, 2023
@dnalborczyk
Copy link
Collaborator

close/re-open in order to run ci.

@dnalborczyk dnalborczyk changed the title Fix/async behaviour fix: async behaviour Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants